-
Notifications
You must be signed in to change notification settings - Fork 53
feat: AST pretty-printer #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approach is fine, we can also make individual methods public, eg for expr
791df5c
to
1865f8e
Compare
@DaniPopes this should be complete, though no tests yet — unsure if we need those and what'd be the best approach to write them should we add some helpers to check whether two ASTs are identical? |
I was thinking if there's a method on ast nodes to "peek" into the relevant portion of the source code that would be great too |
You can add a -Z flag only used in these tests that re-parses pretty printed code; it should also print it to stdout so it gets checked out in a stdout file
Please check out the |
Is this PR pending because of lack of tests? Wanted to help get this PR cross the line |
I'm currently in the process of rewriting forge fmt using solar, I believe we will be able to upstream that implementation so closing for now |
Hi! Any progress for the new implementation? Or is it open-sourced? |
Closes #27